Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Introduce MaxPrivacyChars for PrivacyContentControl #11771

Merged
merged 2 commits into from
Nov 6, 2023
Merged

[VDG] Introduce MaxPrivacyChars for PrivacyContentControl #11771

merged 2 commits into from
Nov 6, 2023

Conversation

wieslawsoltes
Copy link
Collaborator

Fixes: #11730

image

@wieslawsoltes wieslawsoltes mentioned this pull request Oct 22, 2023
Open
29 tasks
yahiheb
yahiheb approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

MarnixCroes
MarnixCroes reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it reveals the labels when hovering over the column.
It should only reveal the items when hovering over the chars, like at other places.

@wieslawsoltes
Copy link
Collaborator Author

it reveals the labels when hovering over the column. It should only reveal the items when hovering over the chars, like at other places.

Yeah this is how it currently works because how TDG layout works I have to measure with extra space in LabelsItemsPresenter control (LabelsPanel to be exact). No easy solution for now, anything I did try breaks labels column in history table.

soosr
soosr approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for now

@soosr soosr merged commit 7325103 into WalletWasabi:master Nov 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarnixCroes MarnixCroes MarnixCroes left review comments

@soosr soosr soosr approved these changes

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] discreetmode: labels column full of privacychars
4 participants
@wieslawsoltes @soosr @yahiheb @MarnixCroes