Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] UI Decoupling #52 #11800

Merged
merged 10 commits into from
Oct 26, 2023
Merged

[VDG] UI Decoupling #52 #11800

merged 10 commits into from
Oct 26, 2023

Conversation

ichthus1604
Copy link
Collaborator

@ichthus1604 ichthus1604 commented Oct 25, 2023 •
edited

  • Decouples WalletStatsViewModel
  • Introduces WalletStatsModel
  • Partially Decouples WalletViewModel

@soosr
Copy link
Collaborator

soosr commented Oct 26, 2023

Going to review it after #11805.

soosr
soosr approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr
Copy link
Collaborator

soosr commented Oct 26, 2023

CF is wrong.

@soosr soosr merged commit 12f35d0 into WalletWasabi:master Oct 26, 2023
6 of 7 checks passed
@ichthus1604 ichthus1604 mentioned this pull request Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ichthus1604 @soosr