[VDG] UI Decoupling #53 #11801
Merged
[VDG] UI Decoupling #53 #11801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soosr
reviewed
Oct 26, 2023
WalletWasabi.Fluent/ViewModels/Wallets/Advanced/WalletCoins/WalletCoinsViewModel.cs
Outdated
Show resolved
Hide resolved
WalletWasabi.Fluent/ViewModels/Wallets/WalletSettingsViewModel.cs
Outdated
Show resolved
Hide resolved
I think you already removed the workaround 😁 The problem we had before this PR is that we were using and old version of DynamicData (the minimum version to satisfy other dependencies), so we were missing the latest features that were added lately. Some of them will greatly help us simplify/improve our code. As a side note and always my opinion, we should look to the DynamicData project with attention and try to be as skilled a possible. It always pays off!. It's one of the most powerful libraries that I've found out there. |
|
Coinjoins were finished, but the indicators are still active: |
Fixed |
soosr
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainViewModelDynamicDatato latest versionWalletModel.IsCoinjoiningbool property, as a workaround for missing DynamicData functionality. @SuperJMN can you comment on what's required to remove this?