[VDG] UI Decoupling #55 #11811
Merged
[VDG] UI Decoupling #55 #11811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soosr
previously approved these changes
Oct 30, 2023
| .MergeMany(x => x.Transactions.NewTransactionArrived) | ||
| .Where(x => !UiContext.ApplicationSettings.PrivacyMode) | ||
| .Where(x => x.EventArgs.IsNews) | ||
| .Where(x => !IsBusy) |
There was a problem hiding this comment.
The notification should be received even if IsBusy is true, the OnClick should not do anything when it is true.
There was a problem hiding this comment.
BWT IsBusy doesn't seem to be set anywhere
There was a problem hiding this comment.
@ichthus1604 this commit d01b0a4 fixes it, please check and open a separate PR if you can improve it further
soosr
previously approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WalletManagerViewModel(finally!!!!)WalletNotificationsViewModelIWalletSelectorinterface to augmentIWalletNavigator