Config: Remove converter
#11834
Merged
Config: Remove converter
#11834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Oct 29, 2023
| @@ -14,6 +14,8 @@ namespace WalletWasabi.Daemon; | |||
|
|
|||
| public class Config | |||
| { | |||
| public static readonly IDictionary EnvironmentVariables = Environment.GetEnvironmentVariables(); | |||
There was a problem hiding this comment.
Moved to a static variable to avoid executing it multiple times.
kiminuo
commented
Oct 29, 2023
| return false; | ||
| } | ||
|
|
||
| public static T[] GetValues<T>(string key, string[] args, Func<string, T> converter) | ||
| public static string[] GetValues(string key, string[] args) |
There was a problem hiding this comment.
Converter was unused.
kiminuo
commented
Oct 29, 2023
| { | ||
| var values = GetValues(key, args, converter); |
There was a problem hiding this comment.
Calling GetValues does not make too much sense because we just use first value we find.
adamPetho
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor for #11764
Measurements
No big change is expected here. Measured using Release configuration.
PR
153 ms
152 ms
154 ms
152 ms
147 ms
master
150 ms
156 ms
155 ms
153 ms