[UI] History - fix CJ group amounts (alternative) #11839
Conversation
| @@ -40,7 +40,7 @@ public partial class TransactionModel : ReactiveObject | |||
|
|
|||
| public Money? Fee { get; init; } | |||
|
|
|||
| public Money Amount => Math.Abs(IncomingAmount ?? OutgoingAmount ?? Money.Zero); | |||
| public Money Amount => IncomingAmount ?? -(OutgoingAmount ?? Money.Zero); | |||
There was a problem hiding this comment.
I believe the amount should be either negative or positive, depending if it was an outgoing or incoming transaction.
Previously it was always positive which was misleading.
There was a problem hiding this comment.
WDYM? What is this amount field?
There was a problem hiding this comment.
@yahiheb the TransactionModel.Amount property is a unification of the IncomingAmount and OutgoingAmount (as shown above) and is used in several places in the UI logic that creates the transaction tree (TransactionTreeBuilder). In the future if these columns are unified in the UI the Amount value can be displayed in the UI as well.
There was a problem hiding this comment.
Imo this is not the correct solution.
Check my review here #11838 (review)
ichthus1604
dismissed
yahiheb’s stale review
This PR fixes a bug currently on master.
fixes #11818
closes #11838