Do not ban our own coinjoin outputs #11861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolay
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
I thought about it as well during the previous PR but didn't think it was necessary.
Anyway, it is clear that there is still a problem here, so this PR is worth a shot.
Clever locks would probably be an alternative, but I prefer this approach, easier to understand.
|
Yes, I agree. Btw, I think this is not really necessary because I haven't seen any problem of this kind but just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply verify the tx is not a coinjoin to make sure we never ban its outputs.