[refactoring] Introduce ConfigManager 1/n
#11875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Nov 5, 2023
| @@ -38,26 +38,6 @@ public void AssertFilePathSet() | |||
| } | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public bool CheckFileChange() | |||
There was a problem hiding this comment.
Only used by Backend in ConfigWatcher. Moved to ConfigManager.
kiminuo
commented
Nov 5, 2023
| throw new FileNotFoundException($"{GetType().Name} file did not exist at path: `{FilePath}`."); | ||
| } | ||
|
|
||
| lock (FileLock) |
There was a problem hiding this comment.
This lock has been removed. The rationale is that Backend is supposed to
- Read its config file.
- Use
ConfigWatcherto re-load its configuration.
No other code is supposed to touch the config file. For this reason, I believe the change is safe.
adamPetho
approved these changes
Nov 6, 2023
| public async Task CheckFileChangeTestAsync() | ||
| { | ||
| string workDirectory = await Common.GetEmptyWorkDirAsync(); | ||
| string configPath = Path.Join(workDirectory, "testConfig.json"); |
There was a problem hiding this comment.
Nit: How come you use Path.Join and not Path.Combine? Both works fine, I'm just curious.
There was a problem hiding this comment.
I just forgot that we use Path.Combine more often. However, the two methods behave the same here so there is no difference really AFAIK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11860