Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE_TEMPLATE: comment out example/help text #11891

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

MarnixCroes
Copy link
Collaborator

Over time, several people who opened an issue didn't remove the help/example text.
So it was shown when reading the issue.

Commenting it out makes the issue look better and easier to read, when the issue opener doesn't remove it.

Copy link
Collaborator

@adamPetho adamPetho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how the .md files now look, and if that is how they will look like if one wants to open an issue, then we can simply remove the help text because it is not needed anymore.

image

image

@MarnixCroes
Copy link
Collaborator Author

when opening an issue, you see the Code not the Preview

when opening an issue it looks like this

image

the change is only for the preview, so when the issue is opened it doesn't look like this

image

it looks like this

image

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea to comment out the help text is good but since we are at it how about simplifying the bug-report template to only have the General Description section, or maybe even leave it completely blank, because most of the time when users open issues they never fill the other sections.

@@ -6,7 +6,7 @@ about: Report a bug

### General Description

A clear and concise description of what the bug is.
<!-- A clear and concise description of what the bug is. -->

### How To Reproduce?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The steps example below could be also commented out here.

Comment on lines 32 to 34
```
Insert Your Logs Here
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be commented out too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no because the the logs should be pasted there.
when you comment it out, then it's not shown...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of issue openers don't use any of those, that's the motive for this PR in the first place right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no.
if logs don't get entered (while applicable) that's a problem of the person filling it in "incorrectly", it's not a problem of the template itself

@turbolay
Copy link
Collaborator

turbolay commented Nov 7, 2023

only have the General Description section, or maybe even leave it completely blank, because most of the time when users open issues they never fill the other sections.

I would also go into this direction. We could have the template like this:

Provide a general description of your problem with relevant information such as Operating System, Wasabi Version, Screenshot, Logs...

@MarnixCroes
Copy link
Collaborator Author

only have the General Description section, or maybe even leave it completely blank, because most of the time when users open issues they never fill the other sections.

I would also go into this direction. We could have the template like this:

Provide a general description of your problem with relevant information such as Operating System, Wasabi Version, Screenshot, Logs...

nack, current issue template works fine, I don't see a reason to change it.
This PR was just to pollish it to only have the helptext visible when filling it in, and not in the preview.
afaik all "mature" projects (on github) have a detailed template.
The template is mostly for (non-technical) users who make a report.
They don't know what is useful information for us to know what happened/what's the issue.
Having the mutiple sections/steps is a good thing, to minimize the amount of reports with too little info (/have a structured manner).

@turbolay
Copy link
Collaborator

Please comment How to Reproduce part, maybe also the logs (not sure about this one) for consistency and we can merge the PR.

@MarnixCroes
Copy link
Collaborator Author

Please comment How to Reproduce part, maybe also the logs (not sure about this one) for consistency and we can merge the PR.

why?
That's info that needs to be filled in.
If you comment it out then it's not visible

@turbolay
Copy link
Collaborator

If you comment it out then it's not visible

Isn't it the whole point of your PR?

You are commenting out some parts but not everything without any apparent reason.
What is the difference between Example: Ubuntu 16.04, that you commented out, and the example "How to Reproduce" flow that you don't want to comment?

Both information "needs to be filled in".

@turbolay
Copy link
Collaborator

turbolay commented Nov 20, 2023

Ok, I understood your point. "needs to be filled in", you mean "required".

Well, in this case, isn't the whole PR wrong? Because ALL the information is "required". Knowing Wasabi's version is equally important as knowing the reproduction steps, otherwise, we have to ask "are you sure you are on the latest version?" Same goes for the OS.

So, for me, both the concept and the implementation are questionable at best, and wrong at worst.

Anyway, it seems Yahia and I are the only ones who don't like it, and I don't care enough to really fight that so @adamPetho, if you think everything is good please merge.

@MarnixCroes
Copy link
Collaborator Author

Ok, I understood your point. "needs to be filled in", you mean "required".

no not really.
What I mean is at how to repro there are the steps, and in the steps there is ..., where the user is supposed to enter the thing
Click on ... -> Click on Receive. so user enters there.
same for logs, user double clicks on Insert your logs here and then pastes.

where as other steps user should just type in and the text is only as example/help.
(not "interactive")

@adamPetho
Copy link
Collaborator

I have no idea what's going on under this PR.

All I know is that I would rather see an issue with minimal user provided text than having to decypher the useful information out of the placeholder texts. This is why I approved this PR in the first place.

@yahiheb @turbolay Guys, if you feel this is horrible and there are clear issues, please point them out or suggest fixes.

If I see no fights/NACKs under this PR until tomorrow, I will merge it. Thanks.

@yahiheb
Copy link
Collaborator

yahiheb commented Nov 20, 2023

#11971 is a very good example that in practice the bug-report template in its current form is not useful for most users. The user was asked multiple times to provide the logs or to fill the template correctly but failed to do so.
Most of the issues that get opened by users are similar to this example, so what's the point in keeping the template as it is now?

The advanced users who know the importance of proving more information and know how to get it, usually do that by themselves.
The others don't fill the form and we need to tell them how to get the relevant information to share, this is the real issue and I don't see this PR fixing it.

My solution to make the issues easy to read for us is to simplify the bug-report template by leaving it completely blank, or to only have the General Description section.

@adamPetho
Copy link
Collaborator

This goes in the right direction, but please find common ground with the guys. Thanks.

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this PR as it is now to not take more time from others unnecessarily.

Further improvements can be done in the future if necessary.

@yahiheb yahiheb merged commit 731a664 into WalletWasabi:master Nov 21, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants