Use TransactionFactoryParameters in tests
#11987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Nov 23, 2023
Comment on lines
-37
to
-52
| /// <exception cref="ArgumentException"/> | ||
| /// <exception cref="ArgumentNullException"/> | ||
| /// <exception cref="ArgumentOutOfRangeException"/> | ||
| public BuildTransactionResult BuildTransaction( | ||
| PaymentIntent payments, | ||
| FeeRate feeRate, | ||
| IEnumerable<OutPoint>? allowedInputs = null, | ||
| IPayjoinClient? payjoinClient = null, | ||
| Func<LockTime>? lockTimeSelector = null, | ||
| bool allowUnconfirmed = true, | ||
| bool allowDoubleSpend = false, | ||
| bool tryToSign = true) | ||
| { | ||
| TransactionParameters parameters = new(payments, feeRate, allowUnconfirmed, allowDoubleSpend, allowedInputs, tryToSign); | ||
| return BuildTransaction(parameters, lockTimeSelector, payjoinClient); | ||
| } |
There was a problem hiding this comment.
This is sort of the main change of this PR.
kiminuo
commented
Nov 23, 2023
|
|
||
| namespace WalletWasabi.Tests.Helpers; | ||
|
|
||
| public class TransactionParametersBuilder |
There was a problem hiding this comment.
This might get promoted from the test project to a different project if there is a for it need. I sort of thing there will be, but not just yet.
kiminuo
commented
Nov 24, 2023
Comment on lines
-21
to
-32
| public static PSBT GenerateRandomTransaction() | ||
| { | ||
| var key = new Key(); | ||
| var tx = | ||
| Network.Main.CreateTransactionBuilder() | ||
| .AddCoins(Coin(0.5m, key.PubKey.GetScriptPubKey(ScriptPubKeyType.Segwit))) | ||
| .AddKeys(key) | ||
| .Send(BitcoinFactory.CreateScript(), Money.Coins(0.5m)) | ||
| .BuildPSBT(true); | ||
| tx.Finalize(); | ||
| return tx; | ||
| } |
kiminuo
commented
Nov 24, 2023
| @@ -94,7 +82,11 @@ public void LazyPayjoinServerTest() | |||
| using Key key = new(); | |||
| PaymentIntent payment = new(key.PubKey, amount); | |||
|
|
|||
| var tx = transactionFactory.BuildTransaction(payment, new FeeRate(2m), allowedCoins.Select(x => x.Outpoint), payjoinClient); | |||
There was a problem hiding this comment.
Fee rate is very often 2, so that was put in the CreateBuilder() method.
kiminuo
commented
Nov 24, 2023
kiminuo
force-pushed
the
feature/2023-11-23-TransactionParameterBuilder
branch
from
f3d8afb
to
337cdb8
Compare
kiminuo
force-pushed
the
feature/2023-11-23-TransactionParameterBuilder
branch
from
337cdb8
to
e023942
Compare
kiminuo
commented
Nov 24, 2023
|
|
||
| public static SmartCoin[] CreateCoins( |
There was a problem hiding this comment.
Extracted from the CreateTransactionFactory method. I believe it will be useful down the line.
Szpoti
approved these changes
Nov 24, 2023
|
I think we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11738
Easier to review commit by commit.