[UI] Fix CoinJoin group status tooltip

[adamPetho]

PR:

Master:

I remember fixing this issue before... or was it only a dream?
Anyways, here is the fix.

[MarnixCroes]

I remember fixing this issue before

me too

---

it's also not correct when all cj are confirmed, it should just say confirmed
could you fix it aswell?

[yahiheb]

LGTM

[yahiheb]

I remember fixing this issue before... or was it only a dream?

This PR #11641

[AlexisKv]

LGTM

[soosr]

@adamPetho
By the usage, It seems to me GetConfirmationText() is meant to be used only for generating the Confirmed text.
In the method UpdateCoinjoinGroup I believe we should just get the confirmationtooltip of the transaction that has the lowest confirmation number.
Why? Because if we have the FeeRate for that transaction, its message will also contain the confirmation time (in the case of pending) so the coinjoin group can also mention that.
This would result in a better UX.

coinjoinGroup.ConfirmedTooltip = coinjoinGroup.Children.MinBy(x => x.Confirmations)?.ConfirmedTooltip ?? "";

What do you think?

[yahiheb]

tACK

[MarnixCroes]

why is this merged?
this #11990 (review) is not fixed

[adamPetho]

this #11990 (review) is not fixed

@MarnixCroes I didn't "fix" it all this time, because IMO there is nothing to fix there. I don't think that's an issue.
If you strongly believe it is, please make a separate issue and let the gods decide its fate.