Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to use new Windows RID #12095

Merged

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Dec 18, 2023

Follow-up to #11897

Continuous delivery is red. Hopefully, this PR fixes that.

@kiminuo kiminuo marked this pull request as ready for review December 18, 2023 18:49
Copy link
Collaborator

@adamPetho adamPetho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to check that this PR fixes the ContinuousDelivery without merging.

According to https://learn.microsoft.com/en-us/dotnet/core/rid-catalog the change looks good.

@kiminuo
Copy link
Collaborator Author

kiminuo commented Dec 19, 2023

I don't know how to check that this PR fixes the ContinuousDelivery without merging.

IMHO we need to be willing to merge it and revert it if it does not fix the issue.

@adamPetho
Copy link
Collaborator

IMHO we need to be willing to merge it and revert it if it does not fix the issue.

Sounds good to me.

@adamPetho adamPetho merged commit 8a55639 into WalletWasabi:master Dec 19, 2023
7 checks passed
@adamPetho
Copy link
Collaborator

DeterministicBuild and ContinuousDelivery were fixed by this. 🎉

@kiminuo kiminuo deleted the feature/2023-12-18-net8-followup branch December 19, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants