AllTransactionStore: Fix accessibility modifiers
#12096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Dec 20, 2023
| { | ||
| lock (Lock) | ||
| { | ||
| AddOrUpdateNoLock(tx); |
There was a problem hiding this comment.
I just inlined this method.
kiminuo
commented
Dec 20, 2023
| @@ -153,23 +148,23 @@ public IEnumerable<SmartTransaction> GetTransactions() | |||
| } | |||
| } | |||
|
|
|||
| public IEnumerable<uint256> GetTransactionHashes() | |||
| internal IEnumerable<uint256> GetTransactionHashes() | |||
There was a problem hiding this comment.
Useful only in tests, so marked as internal to make it more obvious.
kiminuo
deleted the
feature/2023-11-28-AllTransactionStore-accessiblity-modfiers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows what the API actually is.
internalmethods are needed only for tests.