UpdateManager: Clean up the weird cancellation token
#12129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamPetho I attempted to clean up the implementation a bit more. I believe that it's better to propagate cancellation tokens explicitly (it's a standard in the codebase) and it allows to use linked CTs, etc. |
|
Damn, I'm late to my own PR. 😅 Thanks @kiminuo!! The changes looks very good! |
turbolay
approved these changes
Dec 23, 2023
kiminuo
changed the title
UpdateManager: Clean up the weird cancellation token
kiminuo
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #12121 (comment)
Previously, the application stopping token (from
Global.cs) was sent in, saved and used by this class for reasons I don't know.Which makes no sense, since the class is disposable and the GC will handle this job.
Therefore a simple
CTSis sufficient IMO.