Use the IDictionary.TryGetValue(TKey, out TValue) method to fix CA1854 warnings
#12152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolay
approved these changes
Dec 28, 2023
WalletWasabi.Tests/UnitTests/WabiSabi/Backend/Rounds/MultipartyTransactionStateTests.cs
Outdated
Show resolved
Hide resolved
| @@ -163,12 +163,13 @@ private List<SmartCoin> GenerateSmartCoins(IEnumerable<(string Cluster, decimal | |||
| { | |||
| var key = KeyManager.GenerateNewKey(new LabelsArray(targetCoin.Cluster), KeyState.Clean, false); | |||
|
|
|||
| if (!generatedKeyGroup.ContainsKey(targetCoin.Cluster)) | |||
| if (!generatedKeyGroup.TryGetValue(targetCoin.Cluster, out List<(HdPubKey key, decimal amount)>? value)) | |||
There was a problem hiding this comment.
Rider always recommends here to use var. I know @kiminuo prefers very much to be specific all the time. Personal choice I guess, it's a discussion we're having all the time. Feel free to leave it as you did, simply a comment.
There was a problem hiding this comment.
Using var makes reviews less friendly for people not using an IDE. Not everyone has an IDE. Not everytime one wants to switch to a different branch just because a complex line of code is vared. var can silently change code semantics during refactorings, etc. etc.
Anyway, #7153 was rejected, so it's up to everyone who likes what.
kiminuo
reviewed
Dec 28, 2023
kiminuo
reviewed
Dec 28, 2023
kiminuo
changed the title
IDictionary.TryGetValue(TKey, out TValue) method to fix CA1854 warnings
turbolay
approved these changes
Dec 31, 2023
kiminuo
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1854