WalletFilterProcessor: Minor refactoring
#12170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolay
approved these changes
Jan 2, 2024
| _lastProcessedFilter = value; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you explain why is this important please? I do not understand it.
There was a problem hiding this comment.
Because LastProcessedFilter is accessed from multiple threads. In that situation, lock (..) or any other synchronization primitive should be used.
It serves also as a self-documentation that something like that actually happens.
turbolay
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves a few minor things that I noticed while researching #12148.
Please review commit by commit (each one can be a mini PR).