Fix RpcMonitor init in HealthMonitor

[ichthus1604]

Fixes #12066

[molnard]

tACK - please review my additions.

[molnard]

If anyone is reviewing this. The solution might seem to be a hack. But the UI needs to be displayed and some services initializes later and that is a legitimate situation. What should the UI do if the service is not ready or not even exist? The question answered here by a loop and null check. This is fixing the issue.

I checked alternate solutions on the business side and got more ugly solutions.

[yahiheb]

tACK

[ichthus1604]

@molnard A more nuanced and general solution to this problem is to wrap the services in a monad (Task). Then the UI code could request them like this:

var someService = await Services.GetAsync<SomeService>();

which would await until the service is ready. That would remove the endless loop (which I got to admit is a little hacky). Only downside to this approach is that you can't await inside a constructor, and many of the Model classes in the UI are doing just that: referencing services in their constructor and performing event handling on them.

If we moved more of the UI code to asyncs instead of ctors, we could further defer the dependencies from the UI code to these services, which means we could start the UI earlier.

[molnard]

which means we could start the UI earlier

That is a goal I would like us to achieve until the next release. I noticed lately with the releases that the Wasabi window pops up slowly. It is almost 10 seconds on my laptop.