Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix osx dock icon issues #12210

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix osx dock icon issues #12210

merged 2 commits into from
Jan 22, 2024

Conversation

danwalmsley
Copy link

@danwalmsley danwalmsley commented Jan 8, 2024 •
edited by MaxHillebrand

closes #8151
closes #8665

turbolay
turbolay reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@turbolay turbolay left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, didn't look code

yahiheb
yahiheb requested changes Jan 9, 2024
View reviewed changes
Directory.Build.props Outdated Show resolved Hide resolved
WalletWasabi.Fluent/ApplicationStateManager.cs Outdated Show resolved Hide resolved
@yahiheb
Copy link
Collaborator

yahiheb commented Jan 9, 2024

Does this PR fix #8151 and/or #8665?

@soosr
Copy link
Collaborator

soosr commented Jan 9, 2024

Does this PR fix #8151 and/or #8665?

Both

@danwalmsley danwalmsley mentioned this pull request Jan 17, 2024
Merged
soosr
soosr approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I cannot test this, so trusting on the other's tests.

@soosr soosr merged commit 3ab5f8e into WalletWasabi:master Jan 22, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolay turbolay turbolay left review comments

@yahiheb yahiheb yahiheb requested changes

@soosr soosr soosr approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OSX] Can't reopen wallet form dock if running in background OSX: Dock icon behavior when in background
4 participants
@danwalmsley @yahiheb @soosr @turbolay