KeyManager: Introduce GetBestHeight(SyncType)

[kiminuo]

Not sure if it's a good idea or not. WDYT @turbolay?

[turbolay]

I see no harm in this.
I designed that way while implementing TurboSync because my rule of thumb for living a happy life is to never touch existing behavior in the KeyManager

It's however true that the API simply makes more sense that way.
I believe that in the same PR we could remove SetBestHeights, and apply the same change and remove SetTurboSyncHeight in favour of SetHeight(syncType).

[kiminuo]

What I can imagine is to modify KeyManager in the following way:

-public void SetBestHeight(Height height, bool toFile = true)
-public void SetBestTurboSyncHeight(Height height, bool toFile = true)
-public Height GetBestHeight()

and one would be responsible to call KeyManager.Method(SyncType, ...). WDYT?

I find that better because it forces people to think about the sync type (as it is important)

[adamPetho]

tACK

[turbolay]

and one would be responsible to call KeyManager.Method(SyncType, ...). WDYT?
I find that better because it forces people to think about the sync type (as it is important)

I think it's better as well.