-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Distinguish between 1 and multiple addresses for copy button #12224
[UI] Distinguish between 1 and multiple addresses for copy button #12224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
@SuperJMN Pushed some changes to remove the ugly part, please check if you are happy with the current code. |
Your changes are smart and clear. Definitely an improvement over my initial approach. Great job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tack 0a3a1c2
bit of a nit: if there's more than 1 address, I need to hover over the address for the copy button to show up.
could it have the same behavior as single address: hover over the context line for copy to show up?
maybe this is out of scope for this PR as this also applies for TXID's at coinjoins details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Not possible.
Make sense to me to add it here. @SuperJMN Can you apply the same modifications? |
It only applies when there's only one address. But I don't know if that's even possible. @soosr is this OK? |
on master, hovering over the content line of single cj, already gives the copy button. So then there is no change in behavior right? |
For multiple addresses, no 😅 |
You were right, it is not even possible. Coinjoin group can never have 1 cj item... |
Context: Transaction Info / Addresses item.
Fixes #11985
Note: This is the easiest way I have figured out to get a good UX, although I'm not generally fine with incresing complexity for such a little gain.