Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] Remove unused code #12233

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[Trivial] Remove unused code #12233

merged 1 commit into from
Jan 16, 2024

Conversation

yahiheb
Copy link
Collaborator

@yahiheb yahiheb commented Jan 12, 2024

No description provided.

@yahiheb yahiheb requested a review from kiminuo January 12, 2024 08:51
@kiminuo
Copy link
Collaborator

kiminuo commented Jan 12, 2024

There is #12219 which might be in conflict with this one. I think @lontivero would know better than me if your change is OK.

I think it's better to wait until #12219 is merged.

adamPetho
adamPetho approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@adamPetho adamPetho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#12219 got merged.

This is still unused, so LGTM.

@lontivero lontivero merged commit ed4ee1c into WalletWasabi:master Jan 16, 2024
7 checks passed
@yahiheb yahiheb deleted the unused-code branch January 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamPetho adamPetho adamPetho approved these changes

@kiminuo kiminuo Awaiting requested review from kiminuo

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yahiheb @kiminuo @adamPetho @lontivero