[trivial] Remove IRepository and replace it with IFileSystemBlockRepository
#12236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Jan 12, 2024
| @@ -109,7 +109,7 @@ public async Task TestServicesAsync(string networkString) | |||
| ExpirationScanFrequency = TimeSpan.FromSeconds(30) | |||
| }); | |||
|
|
|||
| IRepository<uint256, Block> blockRepository = bitcoinStore.BlockRepository; | |||
| IFileSystemBlockRepository blockRepository = bitcoinStore.BlockRepository; | |||
There was a problem hiding this comment.
This is what the PR is about. Just change IRepository<uint256, Block> to IFileSystemBlockRepository.
kiminuo
commented
Jan 12, 2024
| /// <summary> | ||
| /// IRepository is a generic abstraction of a repository pattern | ||
| /// </summary> | ||
| public interface IRepository<TID, TElement> |
There was a problem hiding this comment.
Replaced with IFileSystemBlockRepository.cs
kiminuo
commented
Jan 12, 2024
|
|
||
| namespace WalletWasabi.Tests.UnitTests.Wallet; | ||
|
|
||
| public class MockBlockRepository : IRepository<uint256, Block> |
There was a problem hiding this comment.
Replaced with MockFileSystemBlockRepository
kiminuo
changed the title
IRepository and replace it with IFileSystemBlockRepositoryIRepository and replace it with IFileSystemBlockRepository
adamPetho
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a helper PR for #12184 that allows easier mocking. It's also a general cleanup because
IRepository<TID, TElem>is used only for block repository purposes and as such it's needlessly generic.