Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move repeating behavior of P2PBlockProvider to SmartBlockProvider #12250

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Move repeating behavior of P2PBlockProvider to SmartBlockProvider #12250

merged 5 commits into from
Jan 15, 2024

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Jan 14, 2024 •
edited

The PR moves the looping behavior from P2PBlockProvider to SmartBlockProvider. This change makes P2PBlockProvider more useful as a "building block".

The PR is meant as a helper PR for #12184.

To understand the PR, it's good to check one commit at a time and then review whole PR with whitespace off.

@kiminuo kiminuo changed the title [refactoring] P2PBlockProvider refactoring [refactoring] P2PBlockProvider Jan 14, 2024
@kiminuo kiminuo changed the title [refactoring] P2PBlockProvider Move repeating behavior of P2PBlockProvider to SmartBlockProvider Jan 14, 2024
@kiminuo kiminuo marked this pull request as ready for review January 14, 2024 20:50
turbolay
turbolay approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@turbolay turbolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this PR would help us with #12184, so in that sense I'm not against merging, but I believe that this while should be entirely removed, and instead the loop be sole responsibility of the BlockDownloadService

@kiminuo
Copy link
Collaborator Author

kiminuo commented Jan 15, 2024

Probably this PR would help us with #12184, so in that sense I'm not against merging, but I believe that this while should be entirely removed, and instead the loop be sole responsibility of the BlockDownloadService

Yes and this PR allows us to do that.

@kiminuo kiminuo mentioned this pull request Jan 15, 2024
Merged
molnard
molnard approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@molnard molnard merged commit 7557f00 into WalletWasabi:master Jan 15, 2024
7 checks passed
@kiminuo kiminuo deleted the feature/2024-01-14-P2PBlockProvider-refactoring branch January 15, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@turbolay turbolay turbolay approved these changes

@adamPetho adamPetho Awaiting requested review from adamPetho

@yahiheb yahiheb Awaiting requested review from yahiheb

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiminuo @molnard @turbolay