Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use INotifyPropertyChanged instead of base in WasabiSynchronizer #12262

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Use INotifyPropertyChanged instead of base in WasabiSynchronizer #12262

merged 1 commit into from
Jan 16, 2024

Conversation

molnard
Copy link
Collaborator

@molnard molnard commented Jan 16, 2024

Alternative and working solution to #12261

@molnard molnard marked this pull request as ready for review January 16, 2024 13:12
Szpoti
Szpoti approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@Szpoti Szpoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

soosr
soosr approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. The code seem equivalent to me compared what was in the base class.

@molnard molnard merged commit 116e352 into WalletWasabi:master Jan 16, 2024
5 of 7 checks passed
@molnard molnard mentioned this pull request Jan 16, 2024
Closed
@Szpoti Szpoti mentioned this pull request Jan 17, 2024
Merged
@molnard molnard deleted the nonotif2 branch January 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperJMN SuperJMN SuperJMN approved these changes

@soosr soosr soosr approved these changes

@Szpoti Szpoti Szpoti approved these changes

@ichthus1604 ichthus1604 Awaiting requested review from ichthus1604

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@molnard @SuperJMN @soosr @Szpoti