Introduce PeriodicRunner in WasabiSynchronizer
#12269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szpoti
changed the title
PeriodicRunner in WasabiSynchronizePeriodicRunner in WasabiSynchronizer
|
Arguably |
adamPetho
requested changes
Jan 17, 2024
|
cACK. It looks very good to me. I will review it asap. |
molnard
requested changes
Jan 18, 2024
adamPetho
reviewed
Jan 19, 2024
adamPetho
reviewed
Jan 19, 2024
| @@ -132,7 +133,7 @@ private static ITransactionBroadcasterModel CreateBroadcaster(Network network) | |||
|
|
|||
| private static IAmountProvider CreateAmountProvider() | |||
| { | |||
| return new AmountProvider(Services.Synchronizer); | |||
| return new AmountProvider(Services.HostedServices.Get<WasabiSynchronizer>()); | |||
There was a problem hiding this comment.
Theoretical question:
Isn't it problematic that we require a non-static object inside a static function?
I tested and nothing is broken, just a question.
adamPetho
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built upon #12262, this PR introduces
PeriodicRunnerinWasabiSynchronizeras a base class.With this change we can rework the running logic of
WasabiSynchronizerwhich before was basically a "PeriodicRunnerby hand".Now that the old base class was changed, we can use
PeriodicRunnerinstead to runWasabiSynchronizerregularly.With these changes,
WasabiSynchronizerwas registered as aHostedService.The action logic is the same, a few logical details was tweaked so it fits and behaves the same as before.