Offline Psbt Workflow compatible #12288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahiheb
reviewed
Jan 19, 2024
molnard
previously approved these changes
Jan 22, 2024
We need to merge it and pass it to UI team. They need to handle this Property in Settings option |
Co-authored-by: yahiheb <52379387+yahiheb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Not all Hardware Wallets support offline PSBT via SD card. That is why this PR was created to be able to regulate this in the future.
#Solution
To be able to prepare for this task, I had to go through the datasheet on every device. It is also possible to sign the transaction with PSBT on the other HardwareWallets, but for that, you have to use another external application, which makes PSBT meaningless, because the Hardware Wallet must not be connected to the computer. In this case, it is enough to accept the transaction directly on HarwareWallet while it is connected to the computer.
#Results