Try not to use unconfirmed coins when BnB.

[molnard]

Fixes: #11951

I used the same logic as used for coins in the critical cj phase which is the following currently:

• The pocket selector and coin-selector create an initial tx.
• That is the tx, which is shown to the user on the tx preview dialog.
• BnB checks if the initial tx includes critical coins, if yes then it is allowed to use them in BnB. If the initial tx is not using critical coins, then BnB won't use them either.

This PR adds the same behavior regarding unconfirmed coins.

[adamPetho]

This means if the initial transaction used an unconfirmed coin, then BaB is allowed to choose any coin from Critical phase and vice versa. I think this is wrong.

I think we should separate the two exclusion.

coinsToUse = spentCoins.Any(coinsToExclude.Contains) ? coinsToUse : coinsToUse.Except(coinsToExclude).ToImmutableArray();

coinsToUse = spentCoins.Any(unconfirmedCoins.Contains) ? coinsToUse : coinsToUse.Except(unconfirmedCoins).ToImmutableArray();

or something like this.

[molnard]

I think we should separate the two exclusion.

You are right. I fixed that.

[adamPetho]

LGTM

[MarnixCroes]

utack c79a8ed

[molnard]

Can someone test this? It is not trivial, maybe on RegTest with CTRL C-D

[soosr]

tACK
minor thing (can be ignored if we want to stick to the convention):

[molnard]

@BTCparadigm can you check if this solves your issue?

[soosr]

tACK

[BTCparadigm]

cACK

@molnard unfortunately I can't before next week.

[molnard]

I can't before next week.

We have time until the release so this can stay open until that. Can you test and reply back here?

[BTCparadigm]

@molnard I can't reasonably test this in mainnet at the moment, so anyone willing to play with regtest or with mainnet test coins can do it too.
I will try to make time for it next week but no promises.

[soosr]

@molnard @BTCparadigm

I tested it on regtest, it worked as expected