Fixing large transaction inputs timeout #12337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molnard
requested changes
Feb 2, 2024
Only at this point the program waits indefinitely |
molnard
requested changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #12090
When we send transactions with many inputs to HW, sending the transaction to the device takes longer than usual, so I changed the timeout to dynamic.
Opinion:
A transaction with 1 input takes about 7-10 seconds
For 2 inputs, this number is 14-19 seconds
The current default timeout was 3 minutes. So if, say, in the case of 10 inputs, the number is about 100 seconds, given a safety margin, this should be good.