Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] add HW icons #12390

Merged
merged 5 commits into from
Feb 8, 2024
Merged

[Release] add HW icons #12390

merged 5 commits into from
Feb 8, 2024

Conversation

soosr
Copy link
Collaborator

@soosr soosr commented Feb 8, 2024

@soosr soosr requested review from molnard and Whem February 8, 2024 09:51
yahiheb
yahiheb requested changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is broken.
You need to also cherry pick the commit of #12341

molnard
molnard requested changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

Is this OK?

image

image

@soosr
Copy link
Collaborator Author

soosr commented Feb 8, 2024

tACK.

Is this OK?

Not at all

@soosr
Copy link
Collaborator Author

soosr commented Feb 8, 2024

tACK.
Is this OK?

Not at all

@molnard I cannot repro, any special things to do?

yahiheb
yahiheb previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if this is needed or not but I guess no.

https://github.com/zkSNACKs/WalletWasabi/pull/12341/files#diff-f53c5a3a574f4dc9cb372309b1467b2972fcdb05236fa52d8f1c40378d1847d3

@molnard I cannot repro, any special things to do?

I don't see any issue there.

tACK

@soosr
Copy link
Collaborator Author

soosr commented Feb 8, 2024

I was wondering if this is needed or not but I guess no.

https://github.com/zkSNACKs/WalletWasabi/pull/12341/files#diff-f53c5a3a574f4dc9cb372309b1467b2972fcdb05236fa52d8f1c40378d1847d3

@yahiheb It is needed. At least from UI point of view, without it for BitBox the generic HW icon would pop on adding, and not the BitBox one

@soosr
Copy link
Collaborator Author

soosr commented Feb 8, 2024

I was wondering if this is needed or not but I guess no.
https://github.com/zkSNACKs/WalletWasabi/pull/12341/files#diff-f53c5a3a574f4dc9cb372309b1467b2972fcdb05236fa52d8f1c40378d1847d3

@yahiheb It is needed. At least from UI point of view, without it for BitBox the generic HW icon would pop on adding, and not the BitBox one

Can someone do a PR? @yahiheb @Whem

@yahiheb yahiheb self-requested a review February 8, 2024 11:50
@molnard
Copy link
Collaborator

molnard commented Feb 8, 2024

@Whem will do another PR and re-align the icons.

@Whem Whem mentioned this pull request Feb 8, 2024
Merged
@Whem Whem requested a review from molnard February 8, 2024 14:21
@molnard molnard merged commit b4676e1 into WalletWasabi:release_v2.0.6 Feb 8, 2024
4 checks passed
@adamPetho adamPetho mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Whem Whem Awaiting requested review from Whem

@yahiheb yahiheb Awaiting requested review from yahiheb

@molnard molnard Awaiting requested review from molnard

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soosr @molnard @yahiheb @Whem