-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Avalonia update #12398
[Release] Avalonia update #12398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nothing happens on Windows. |
I am testing the crash reporter.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Crash reporter shows up by using the command line args. That is enough for this PR.
- win
- mac x86
- mac m1
- ubuntu
Can you elaborate on what does this mean? |
If you put dummy exceptions here and there it might not trigger the crash reporter. I did not have time to investigate but that is a not a concern here - the only thing that should be tested here if can show the window. |
Edit: it works, what tricked me is the |
If I throw directly an exception on Fluent's Program.cs , the crash report didn't show up. |
Exactly, the crash reporter works if you trigger it with command line, but doesn't work when you put a dummy exception anywhere in the software. |
And if we separate the crash reporter to another exe? maybe the program is running while we call the exe again. This is not a guarantee of correct operation. |
It was .NET 8 breaking change. Fixed by #12416 |
#12392