Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Avalonia update #12398

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

soosr
Copy link
Collaborator

@soosr soosr commented Feb 8, 2024

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Whem
Copy link
Collaborator

Whem commented Feb 9, 2024

Nothing happens on Windows.

@molnard
Copy link
Collaborator

molnard commented Feb 9, 2024

I am testing the crash reporter.

dotnet run -- 
crashreport -exception="eyJFeGNlcHRpb25UeXBlIjoiU3lzdGVtLkV4Y2VwdGlvbiIsIk1lc3NhZ2UiOiJEdW1teSIsIlN0YWNrVHJhY2UiOiIgICBhdCBXYWxsZXRXYXNhYmkuRmx1ZW50LkRlc2t0b3AuUHJvZ3JhbS5NYWluKFN0cmluZ1tdIGFyZ3MpIGluIFdhbGxldFdhc2FiaS5GbHVlbnQuRGVza3RvcFxcUHJvZ3JhbS5jczpsaW5lIDU1IiwiSW5uZXJFeGNlcHRpb24iOm51bGx9"

Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Crash reporter shows up by using the command line args. That is enough for this PR.

  • win
  • mac x86
  • mac m1
  • ubuntu

@molnard
Copy link
Collaborator

molnard commented Feb 9, 2024

Nothing happens on Windows.

Can you elaborate on what does this mean?

@molnard
Copy link
Collaborator

molnard commented Feb 9, 2024

If you put dummy exceptions here and there it might not trigger the crash reporter. I did not have time to investigate but that is a not a concern here - the only thing that should be tested here if can show the window.

@molnard molnard merged commit a08003d into WalletWasabi:release_v2.0.6 Feb 9, 2024
3 of 4 checks passed
@yahiheb
Copy link
Collaborator

yahiheb commented Feb 9, 2024

It doesn't show the crash reporter window for me on Win 10.

Edit: it works, what tricked me is the -- in David's comments #12398 (comment), they should be removed.

@Whem
Copy link
Collaborator

Whem commented Feb 9, 2024

Nothing happens on Windows.

Can you elaborate on what does this mean?

If I throw directly an exception on Fluent's Program.cs , the crash report didn't show up.

@soosr
Copy link
Collaborator Author

soosr commented Feb 9, 2024

Nothing happens on Windows.

Can you elaborate on what does this mean?

If I throw directly an exception on Fluent's Program.cs , the crash report didn't show up.

Exactly, the crash reporter works if you trigger it with command line, but doesn't work when you put a dummy exception anywhere in the software.
So basically it doesn't work, because it should pop for en exception.

@Whem
Copy link
Collaborator

Whem commented Feb 12, 2024

Nothing happens on Windows.

Can you elaborate on what does this mean?

If I throw directly an exception on Fluent's Program.cs , the crash report didn't show up.

Exactly, the crash reporter works if you trigger it with command line, but doesn't work when you put a dummy exception anywhere in the software. So basically it doesn't work, because it should pop for en exception.

And if we separate the crash reporter to another exe? maybe the program is running while we call the exe again. This is not a guarantee of correct operation.

@soosr
Copy link
Collaborator Author

soosr commented Feb 13, 2024

Nothing happens on Windows.

Can you elaborate on what does this mean?

If I throw directly an exception on Fluent's Program.cs , the crash report didn't show up.

Exactly, the crash reporter works if you trigger it with command line, but doesn't work when you put a dummy exception anywhere in the software. So basically it doesn't work, because it should pop for en exception.

And if we separate the crash reporter to another exe? maybe the program is running while we call the exe again. This is not a guarantee of correct operation.

It was .NET 8 breaking change. Fixed by #12416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants