Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Fix BuyAnything button visibility #12441

Merged
merged 5 commits into from
Feb 13, 2024
Merged

[Release] Fix BuyAnything button visibility #12441

merged 5 commits into from
Feb 13, 2024

Conversation

soosr
Copy link
Collaborator

@soosr soosr commented Feb 12, 2024

@MaxHillebrand MaxHillebrand added this to the v2.0.6 milestone Feb 12, 2024
yahiheb
yahiheb approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

molnard
molnard requested changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask for an extra but only if it is easy to add. Can you make the button always visible in debug mode (not release mode)?

@soosr
Copy link
Collaborator Author

soosr commented Feb 13, 2024

Can I ask for an extra but only if it is easy to add. Can you make the button always visible in debug mode (not release mode)?

Done

molnard
molnard approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@molnard molnard merged commit 4c0ebfc into WalletWasabi:release_v2.0.6 Feb 13, 2024
3 of 4 checks passed
@molnard
Copy link
Collaborator

molnard commented Feb 13, 2024 •
edited

Is this in the master?

@soosr
Copy link
Collaborator Author

soosr commented Feb 13, 2024

Is this in the master?

Not yet

@soosr
Copy link
Collaborator Author

soosr commented Feb 13, 2024

Is this in the master?

Not yet

Done #12459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@yahiheb yahiheb yahiheb approved these changes

@MarnixCroes MarnixCroes MarnixCroes approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
v2.0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@soosr @molnard @yahiheb @MarnixCroes @MaxHillebrand