Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] SendViewModel: Make AmountBtc nullable #12539

Merged
merged 1 commit into from
Feb 22, 2024

Make AmountBtc nullable

030f267
Select commit
Failed to load commit list.
Merged

[VDG] SendViewModel: Make AmountBtc nullable #12539

Make AmountBtc nullable
030f267
Select commit
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (master) failed Feb 22, 2024 in 33s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method SendViewModel.cs: SendViewModel 🔥

✅ Improving Code Health:

  • Large Method SendViewModel.cs: SendViewModel 🔥

Annotations

Check warning on line 127 in WalletWasabi.Fluent/ViewModels/Wallets/Send/SendViewModel.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)

❌ New issue: Complex Method 

SendViewModel has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in WalletWasabi.Fluent/ViewModels/Wallets/Send/SendViewModel.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)

ℹ Getting worse: Overall Code Complexity 

The mean cyclomatic complexity increases from 4.60 to 4.80, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 127 in WalletWasabi.Fluent/ViewModels/Wallets/Send/SendViewModel.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)

✅ No longer an issue: Large Method 

SendViewModel is no longer above the threshold for lines of code
View more details on CodeScene Delta Analysis