Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Make CJ settings more discoverable via MusicBox #12694

Merged
merged 7 commits into from
Mar 22, 2024

Fix problem with Watch-Only wallets

f6918a9
Select commit
Failed to load commit list.
Merged

[UI] Make CJ settings more discoverable via MusicBox #12694

Fix problem with Watch-Only wallets
f6918a9
Select commit
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (master) failed Mar 21, 2024 in 54s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method CoinJoinStateViewModel.cs: CoinJoinStateViewModel 🔥

Annotations

Check warning on line 165 in WalletWasabi.Fluent/ViewModels/Wallets/CoinJoinStateViewModel.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)

❌ New issue: Large Method 

CoinJoinStateViewModel has 78 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis