Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SubActionButton #12841

Merged
merged 28 commits into from
Apr 24, 2024
Merged

Conversation

SuperJMN
Copy link
Collaborator

Fixes #12363

@SuperJMN SuperJMN force-pushed the improvements/subactionbutton branch from 1d3d607 to 2f17cf5 Compare April 15, 2024 09:50
@SuperJMN SuperJMN self-assigned this Apr 18, 2024
@soosr
Copy link
Collaborator

soosr commented Apr 18, 2024

Please keep the original size. The Figma design was created for the default fontsize of 12 but in Wasabi it's 14 so everything is a bit bigger.
Don't have to 100% obey the design.

image

@SuperJMN
Copy link
Collaborator Author

SuperJMN commented Apr 21, 2024

Note: Once this is reviewed and approved, I will restore the original button. The sample button sub-actions are just there to facilitate the visual review of this feature.

@SuperJMN SuperJMN marked this pull request as ready for review April 21, 2024 16:20
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Padding (or margins) and spacings are not consistent. The SubAction button looks different compared to Receive and Buy Anything buttons.

  • Receive and BuyAnything button also seems like to have a kind of outline? SubAction button is much sharper. Should be consistent.
    image

  • Please add a IsDefault property, and implement the little green dot that will indicate it (with a tooltip that says Default)
    image

@SuperJMN SuperJMN requested a review from soosr April 23, 2024 10:10
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit dbf5262 into WalletWasabi:master Apr 24, 2024
4 of 8 checks passed
@SuperJMN SuperJMN deleted the improvements/subactionbutton branch April 24, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] SubAction button
3 participants