-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Add resync button #12959
base: master
Are you sure you want to change the base?
[PoC] Add resync button #12959
Conversation
Few notes on a Resync Button, not on the implementation:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK
Just few additional notes and nits:
Caption="Signal to rescan the wallet" | ||
EnableBack="{Binding EnableBack}" | ||
EnableCancel="{Binding EnableCancel}" | ||
EnableNext="True" NextContent="Save" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match the text:
EnableNext="True" NextContent="Save" | |
EnableNext="True" NextContent="OK" |
<InfoMessage> | ||
<DockPanel> | ||
<Button Margin="50 0" Theme="{StaticResource AccentButton}" Command="{Binding SignalWalletResyncCommand}" Content="Resync Wallet" DockPanel.Dock="Right" /> | ||
<TextBlock Text="If your funds are missing, you can resynchronize wallet. Once you restart Wasabi, it can take several hours to rescan and find all your funds." /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<TextBlock Text="If your funds are missing, you can resynchronize wallet. Once you restart Wasabi, it can take several hours to rescan and find all your funds." /> | |
<TextBlock Text="If your funds are missing, you can resynchronize your wallet." /> |
</InfoMessage> | ||
<InfoMessage> | ||
<DockPanel> | ||
<TextBlock Text="Rescanning the wallet could take several hours, based on how many transactions your wallet had." /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that can take some time depending on the size of your wallet (how many transactions it had)
<TextBlock Text="Rescanning the wallet could take several hours, based on how many transactions your wallet had." /> | |
<TextBlock Text="Rescanning the wallet could take some time depending mainly on its size (Number of transactions)." /> |
(Messed up my master branch in the last PR)
Fixes #2005
Now the user can press the Resync button under
Wallet Settings
->Tools
.It will open a dialog, and if OK is pressed, the
Height
andTurboSyncHeight
will be set to 0, and the wallet will shut down.Calling
ForceTerminate
is needed because the open dialog won't let Wasabi to terminate the simple way.This means that if coinjoin is in critical state, we will terminate whatsoever. This should be changed.