[v2.0.7.2] Mix to another wallet clean

[Whem]

fixes: #12695

[molnard]

tACK

[molnard]

I will merge this now to be able to create the RC - please still review it. It is moving the user's money.
Pinging @lontivero @turbolay @soosr

[turbolay]

LGTM

[turbolay]

Suggested change

	wallet.ConsolidationMode = outputWallet is not null && outputWallet.WalletId != wallet.WalletId;
	wallet.ConsolidationMode = wallet.ConsolidationMode || (outputWallet is not null && outputWallet.WalletId != wallet.WalletId);

?

[molnard]

Seems to be not correct to me. Once we set the ConsolidationMode to true it won't be able to change it back. Even if the user sets it back and mixes into his own wallet.

[turbolay]

Ok so maybe another change, but right now you basically "hijack" ConsolidationMode with this feature, as it's getting overriden, so we cannot set this settings in any other way that through mixing to other wallet.

[molnard]

That is a correct point theoretically. Practically there is no other usage of ConsolidationMode currently. If you know an easy way to change this we can do it that way on the master. Is it OK to have it this way in the hotfix for the sake of simplicity?

[turbolay]

Yes

[turbolay]

From initial testing:

• Between the CoinjoinClient is started but before inputs registration phase, you can still change the output wallet. It is incorrect because the change won't be taken into account. This is an important problem because everything in the UI tells that Wallet B will receive the outputs when in fact it's Wallet A
  
• Same if you have the dropdown opened while transitioning into the input reg phase. You will still be able to change the selected wallet for outputs, even if this won't be taken into account. This is much less of a deal if the previous issue is fixed, because it will only be possible for it to happen when auto coinjoin starts.

CleanShot.2024-05-08.at.11.10.45.mp4

• Under some conditions that I have not been able to identify, some opened and loaded wallets are not selectable. This happened to me twice