Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Privacy Ring References fix #9466

Merged
merged 7 commits into from
Nov 23, 2022
Merged

[VDG] Privacy Ring References fix #9466

merged 7 commits into from
Nov 23, 2022

Conversation

ichthus1604
Copy link
Collaborator

@ichthus1604 ichthus1604 commented Nov 2, 2022 •
edited

@nopara73 nopara73 mentioned this pull request Nov 21, 2022
Closed
@pull-request-size pull-request-size bot added size/S and removed size/L labels Nov 21, 2022
@ichthus1604
Copy link
Collaborator Author

@zkSNACKs/visual-design-group this is ready to review since dependencies are already merged

Let me know your thoughts

@ichthus1604 ichthus1604 mentioned this pull request Nov 22, 2022
Closed
soosr
soosr approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, code looks good to me.

@soosr
Copy link
Collaborator

soosr commented Nov 22, 2022

@MarnixCroes @BTCparadigm Could you guys test this if this solves your issues?

yahiheb
yahiheb approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested that it fixes #9546

@MarnixCroes
Copy link
Collaborator

@MarnixCroes @BTCparadigm Could you guys test this if this solves your issues?

it fits exactly :)
image

MarnixCroes
MarnixCroes approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@molnard molnard merged commit 230ffaa into WalletWasabi:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

@yahiheb yahiheb yahiheb approved these changes

@MarnixCroes MarnixCroes MarnixCroes approved these changes

@SuperJMN SuperJMN Awaiting requested review from SuperJMN

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anon score gets cut off in privacy ring PrivacyRing: not all references displayed when many
5 participants
@ichthus1604 @soosr @MarnixCroes @yahiheb @molnard