-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VDG] Welcome Page Simplification #9534
[VDG] Welcome Page Simplification #9534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but a bit "horizontally flat", maybe the logo can be below the text?
I would move the "Welcome" text to the top middle and make it a tiny bit bigger. |
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
@MaxHillebrand @soosr please recheck |
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9432b27
last final nit would be to slightly make the final line shorter, so that it is same width as the ones above, but it's not bad, so this can be merged, imo
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 06d1dad
@jmacato This is unreadable on my screen: I think get rid of the |
@soosr Makes sense, lemme try that now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first time a user uses Wasabi they will be faced with:
- This unnecessary welcome pages.
- Creating a new wallet and all its endless steps.
- Terms and Conditions.
For someone who just wants to use bitcoin and try Wasabi, this is very slow and bad UX.
IMO we should just remove these welcome pages for a straightforward and better UX.
The second page is absolutely not needed, just remove it.
With Electrum for example a user directly is faced with creating a wallet, no need for all these marketing texts.
@yahiheb Let's refrain from commenting on the actual concept itself, especially when the PR's concept is already agreed upon. If you want to challenge the concept itself then debate on the channel then write your own PR instead of wasting our time of us opening PR's and you shutting them down just because you don't like them. Review this PR with its code and debate the concept in VDG channel. |
AFAIK Wasabi Wallet is an open source project and people are free and welcome to contribute. Regarding the internal organization, I have not seen this agreed upon concept being discussed in the VDG channel unless it was in some private channel, so probably it should be first discussed there in public to avoid wasting time. |
Yahiheb says this PR is harambo. |
cc @zkSNACKs/visual-design-group