Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Welcome Page Simplification #9534

Merged
merged 12 commits into from
Nov 21, 2022

Conversation

jmacato
Copy link
Contributor

@jmacato jmacato commented Nov 15, 2022

image

cc @zkSNACKs/visual-design-group

Copy link
Collaborator

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but a bit "horizontally flat", maybe the logo can be below the text?

WalletWasabi.Fluent/Views/AddWallet/WelcomePageView.axaml Outdated Show resolved Hide resolved
@soosr
Copy link
Collaborator

soosr commented Nov 15, 2022

This is good, but a bit "horizontally flat", maybe the logo can be below the text?

I would move the "Welcome" text to the top middle and make it a tiny bit bigger. Welcome! Wasabi is feels unnatural, there is no transition in the context.

jmacato and others added 2 commits November 15, 2022 20:54
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
@jmacato
Copy link
Contributor Author

jmacato commented Nov 15, 2022

@MaxHillebrand @soosr please recheck

jmacato and others added 2 commits November 15, 2022 23:33
MaxHillebrand
MaxHillebrand previously approved these changes Nov 15, 2022
Copy link
Collaborator

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9432b27

last final nit would be to slightly make the final line shorter, so that it is same width as the ones above, but it's not bad, so this can be merged, imo

Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
MaxHillebrand
MaxHillebrand previously approved these changes Nov 15, 2022
Copy link
Collaborator

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 06d1dad

@soosr
Copy link
Collaborator

soosr commented Nov 16, 2022

@jmacato
ViewBox on the text should be reconsidered, we need another approach.

This is unreadable on my screen:
image

I think get rid of the Grid and use DockPanel instead. The Text part docked to left and the image part should dock to the right. With this only, the image should change as the window is being resized.

@jmacato
Copy link
Contributor Author

jmacato commented Nov 16, 2022

@soosr Makes sense, lemme try that now

nopara73
nopara73 previously approved these changes Nov 16, 2022
Copy link
Contributor

@nopara73 nopara73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
@jmacato jmacato dismissed stale reviews from nopara73 and MaxHillebrand via b6c7e8c November 16, 2022 11:38
jmacato and others added 2 commits November 16, 2022 19:38
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first time a user uses Wasabi they will be faced with:

  • This unnecessary welcome pages.
  • Creating a new wallet and all its endless steps.
  • Terms and Conditions.

For someone who just wants to use bitcoin and try Wasabi, this is very slow and bad UX.
IMO we should just remove these welcome pages for a straightforward and better UX.
The second page is absolutely not needed, just remove it.

With Electrum for example a user directly is faced with creating a wallet, no need for all these marketing texts.

@jmacato jmacato closed this Nov 19, 2022
@jmacato jmacato deleted the vdg/Welcome_Page_Simplification branch November 19, 2022 15:14
@jmacato jmacato restored the vdg/Welcome_Page_Simplification branch November 19, 2022 15:47
@jmacato jmacato reopened this Nov 19, 2022
@jmacato
Copy link
Contributor Author

jmacato commented Nov 19, 2022

@yahiheb Let's refrain from commenting on the actual concept itself, especially when the PR's concept is already agreed upon. If you want to challenge the concept itself then debate on the channel then write your own PR instead of wasting our time of us opening PR's and you shutting them down just because you don't like them.

Review this PR with its code and debate the concept in VDG channel.

@yahiheb
Copy link
Collaborator

yahiheb commented Nov 19, 2022

AFAIK Wasabi Wallet is an open source project and people are free and welcome to contribute.

Regarding the internal organization, I have not seen this agreed upon concept being discussed in the VDG channel unless it was in some private channel, so probably it should be first discussed there in public to avoid wasting time.

@karozagorus
Copy link
Contributor

karozagorus commented Nov 19, 2022

Yahiheb says this PR is harambo.

@nopara73 nopara73 merged commit df318e2 into WalletWasabi:master Nov 21, 2022
@jmacato jmacato deleted the vdg/Welcome_Page_Simplification branch November 21, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants