Add file verifying to UpdateManager #9535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Szpoti
requested review from
molnard and
adamPetho
and removed request for
molnard
adamPetho
reviewed
Nov 16, 2022
molnard
requested changes
Nov 16, 2022
In the |
molnard
requested changes
Nov 22, 2022
molnard
requested changes
Nov 22, 2022
molnard
requested changes
Nov 28, 2022
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
…tWasabi into addVerifyingToUpdateManager
|
Resolved smells and refactored the code IRL, is ready. |
kiminuo
pushed a commit
to kiminuo/WalletWasabi
that referenced
this pull request
Nov 30, 2022
…Manager Add file verifying to UpdateManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #9259
This PR adds different file verifying methods to the UpdateManager with the help of WasabiSignerHelpers, introduced in #9515 .
Once, upon a new release, it verifies the provided
SHA256SUMS.ascfile, with the (also provided)SHA256SUMS.wasabisig.Then, after the correct installer is downloaded, it verifies the hash of the downloaded file with the expected hash to be found in
SHA256SUMS.asc.