[trivial] IdempotencyRequestCache: Preparation work
#9577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Nov 21, 2022
| @@ -46,7 +46,7 @@ public async Task<RoundStateResponse> GetStatusAsync(RoundStateRequest request, | |||
| public async Task<ConnectionConfirmationResponse> ConfirmConnectionAsync(ConnectionConfirmationRequest request, CancellationToken cancellationToken) | |||
| { | |||
| var before = DateTimeOffset.UtcNow; | |||
| var ret = await IdempotencyRequestCache.GetCachedResponseAsync(request, action: (request, token) => Arena.ConfirmConnectionAsync(request, token), cancellationToken); | |||
| var ret = await IdempotencyRequestCache.GetCachedResponseAsync(request, action: Arena.ConfirmConnectionAsync, cancellationToken); | |||
There was a problem hiding this comment.
Recommended by an analyzer to remove an extra lamda.
kiminuo
commented
Nov 21, 2022
| @@ -95,6 +95,7 @@ public IdempotencyRequestCache(IMemoryCache cache) | |||
| /// <para>Note that if there is a simultaneous request for the cache key, it is not stopped and its result is discarded.</para> | |||
| /// </remarks> | |||
| internal void Remove<TRequest>(TRequest cacheKey) | |||
| where TRequest : notnull | |||
There was a problem hiding this comment.
To unify it. All other methods have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #9469