IdempotentRequestCache: Remove request timeout
#9581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ementation and move it outside
…remove-request-timeout
kiminuo
commented
Nov 28, 2022
Comment on lines
+49
to
+50
| using CancellationTokenSource timeoutCts = new(RequestTimeout); | ||
| using CancellationTokenSource linkedCts = CancellationTokenSource.CreateLinkedTokenSource(timeoutCts.Token, cancellationToken); |
There was a problem hiding this comment.
I have deliberately copy&pasted these two lines to ConfirmConnectionAsync and other methods because if I were to use a method it would be very generic method and probably harder to understand.
That can be still done if you find it better.
kiminuo
commented
Nov 28, 2022
| responseTcs.SetException(!timeoutCts.IsCancellationRequested | ||
| ? e | ||
| : new InvalidOperationException("DeadLock prevention timeout kicked in!", e)); | ||
| responseTcs.SetException(e); |
There was a problem hiding this comment.
This is the main change. The rationale behind this change is: Whatever request timeout we choose, it's certainly not good enough for application-wide use.
So then we can just leaving it up to users of Idempotency Request Cache to specify a timeout they need OR don't specify any timeout at all (block fetching shows that we might wait very long time).
molnard
approved these changes
Nov 29, 2022
kiminuo
deleted the
feature/2022-11-19-IdempotentRequestCache-remove-request-timeout
branch
kiminuo
pushed a commit
to kiminuo/WalletWasabi
that referenced
this pull request
Nov 30, 2022
…IdempotentRequestCache-remove-request-timeout `IdempotentRequestCache`: Remove request timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9577
This is an idea how to fix: #9469 (comment)
The idea is simply to remove
private static TimeSpan RequestTimeout { get; } = TimeSpan.FromMinutes(5);fromIdempotencyRequestCacheand move it simply to the callers that need it.