Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Max Privacy profile equality #9588

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

adamPetho
Copy link
Collaborator

Fixes: #9587

Max Privacy + 50 anon score target gives back Custom coinjoin profile falsely.
This PR fixes this.

@turbolay
Copy link
Collaborator

I found a bug while testing this, even if I don't think it's related
The change is rolled back if I want to set a custom within the private profile range

2022-11-21_07-00-52.mp4

@adamPetho
Copy link
Collaborator Author

I found a bug while testing this, even if I don't think it's related The change is rolled back if I want to set a custom within the private profile range

Not related to this PR, but nice catch!
If I can fix it easily, I will open another PR for it.

Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit b8a2e7c into WalletWasabi:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CJ strategy: Maximize privacy strategy shown as custom when AS target is 50
5 participants