Maximize Privacy CJ Profile Anonscore display fix #9593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolay
previously approved these changes
Nov 23, 2022
WalletWasabi.Fluent/ViewModels/CoinJoinProfiles/CoinJoinProfilesViewModel.cs
Outdated
Show resolved
Hide resolved
yahiheb
requested changes
Nov 23, 2022
WalletWasabi.Fluent/ViewModels/CoinJoinProfiles/CoinJoinProfilesViewModel.cs
Outdated
Show resolved
Hide resolved
yahiheb
previously approved these changes
Nov 23, 2022
soosr
reviewed
Nov 24, 2022
WalletWasabi.Fluent/ViewModels/CoinJoinProfiles/CoinJoinProfilesViewModel.cs
Outdated
Show resolved
Hide resolved
|
@soosr is there a blocker in this PR? |
kiminuo
pushed a commit
to kiminuo/WalletWasabi
that referenced
this pull request
Nov 30, 2022
…e_anonscore_fix Maximize Privacy CJ Profile Anonscore display fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue #9588 (comment) found by @turbolay
The issue:
When we change the anonscore target of the
Maximize PrivacyCoinJoin profile, we save the anonscore target to thekeymanager, but we don't update theMaximize Privacyprofile.So the randomly selected anonscore target (between 50-101) will be displayed instead of the user's selection.
Nice video of the issue can also be found here #9588 (comment)