-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VDG] [Trivial] Improve captions for SearchBar elements #9607
[VDG] [Trivial] Improve captions for SearchBar elements #9607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions to unify those captions.
WalletWasabi.Fluent/ViewModels/HelpAndSupport/DocsLinkViewModel.cs
Outdated
Show resolved
Hide resolved
WalletWasabi.Fluent/ViewModels/HelpAndSupport/UserSupportViewModel.cs
Outdated
Show resolved
Hide resolved
I would also change the following ones: https://github.com/zkSNACKs/WalletWasabi/blob/367ef7c3fc349212641410f352dabe39e8efbe3d/WalletWasabi.Fluent/ViewModels/AddWallet/LegalDocumentsViewModel.cs#L12 to https://github.com/zkSNACKs/WalletWasabi/blob/367ef7c3fc349212641410f352dabe39e8efbe3d/WalletWasabi.Fluent/ViewModels/HelpAndSupport/AboutViewModel.cs#L14 to |
WalletWasabi.Fluent/ViewModels/HelpAndSupport/BugReportLinkViewModel.cs
Outdated
Show resolved
Hide resolved
WalletWasabi.Fluent/ViewModels/HelpAndSupport/DocsLinkViewModel.cs
Outdated
Show resolved
Hide resolved
WalletWasabi.Fluent/ViewModels/HelpAndSupport/UserSupportViewModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider this comment #9607 (comment)
Otherwise this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a request in the past that those buttons that open a website should indicate that it will open something not in the software. Can we use the word website
instead of page
?
WalletWasabi.Fluent/ViewModels/HelpAndSupport/BugReportLinkViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ve-captions [VDG] [Trivial] Improve captions for SearchBar elements
I've observed that some items in Help & Support offer captions that aren't useful and all and feel unprofessional.
This PR fixes them.
Current:
This PR:
Feel free to suggest better texts :)