[minor] Use static instances if available #9610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Nov 24, 2022
| @@ -219,7 +219,7 @@ public ZeroCredentialsRequestData CreateRequestForZeroAmount() | |||
| return credentials.Select(x => new Credential(x.Requested.Value, x.Requested.Randomness, x.Issued)); | |||
| } | |||
|
|
|||
| private Transcript BuildTransnscript(bool isNullRequest) | |||
kiminuo
commented
Nov 24, 2022
| @@ -39,14 +39,14 @@ public static Coin CreateCoin(Key? key = null, Money? amount = null, ScriptPubKe | |||
| public static Tuple<Coin, OwnershipProof> CreateCoinWithOwnershipProof(Key? key = null, Money? amount = null, uint256? roundId = null, ScriptPubKeyType scriptPubKeyType = ScriptPubKeyType.Segwit) | |||
| { | |||
| key ??= new(); | |||
| var coin = WabiSabiFactory.CreateCoin(key, amount, scriptPubKeyType); | |||
There was a problem hiding this comment.
Just simplifies the name
kiminuo
commented
Nov 24, 2022
| => new(RoundParameters.Create(cfg, round.Parameters.Network, round.Parameters.MiningFeeRate, round.Parameters.CoordinationFeeRate, round.Parameters.MaxSuggestedAmount), | ||
| blameOf: round, | ||
| blameWhitelist: round.Alices.Select(x => x.Coin.Outpoint).ToHashSet(), | ||
| InsecureRandom.Instance); |
There was a problem hiding this comment.
Split into multiple lines (the line was too long)
Szpoti
approved these changes
Nov 25, 2022
lontivero
approved these changes
Nov 26, 2022
kiminuo
added a commit
to kiminuo/WalletWasabi
that referenced
this pull request
Nov 30, 2022
* tpyo (see what I did?) * Use static instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.