Fix after #9123 (Select coins for round abstraction) #9615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
commented
Nov 24, 2022
This comment was marked as outdated.
This comment was marked as outdated.
|
Tested and it does work indeed. |
Closed
nopara73
approved these changes
Nov 24, 2022
kiminuo
changed the title
kiminuo
deleted the
feature/2022-11-24-NBitcoinExtensions-scriptTypes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion is here: #9123 (comment)
#9123 breaks the wallet as the wallet cannot work with "unknown script types". This PR fixes that in a minimal way.
ISmartCoininterface is not entirely great because ofScriptTypethat is not nullable but it cannot be easily turned into nullable either. Hopefully, we will find a way to improve it later.Alternative to #9616