Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semiprivate threshold #9635

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

onvej-sl
Copy link
Contributor

This PR allows for implementation of Wabisabi client library which will be used by Trezor.

Szpoti
Szpoti previously approved these changes Nov 28, 2022
Copy link
Collaborator

@Szpoti Szpoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@lontivero
Copy link
Collaborator

LGTM. Please fix the conflicts.

@onvej-sl
Copy link
Contributor Author

LGTM. Please fix the conflicts.

Done.

git range-diff 3bd34b6012120344a8f315721f39792c3818ecbe..6ce15d75aa829bdb86361f0312e2668ad561b2e2 426e1d48b0cdb08717d43e73fe7b7efc0d7ba6a3..HEAD
1:  78792c6bf = 1:  b7373b3f7 Refactor SelectCoinsForRound
2:  6ce15d75a ! 2:  ebaaac5b3 Extend SelectCoinsForRound by parameter semiPrivateThreshold
    @@ WalletWasabi/WabiSabi/Client/CoinJoinClient.cs: public class CoinJoinClient
                SecureRandom = new SecureRandom();
                DoNotRegisterInLastMinuteTimeLimit = doNotRegisterInLastMinuteTimeLimit;
     @@ WalletWasabi/WabiSabi/Client/CoinJoinClient.cs: public class CoinJoinClient
    -   private TimeSpan DoNotRegisterInLastMinuteTimeLimit { get; }
      
    -   public bool ConsolidationMode { get; private set; }
    --  public bool RedCoinIsolation { get; }
    +   private bool ConsolidationMode { get; set; }
    +   private bool RedCoinIsolation { get; }
     +  private int SemiPrivateThreshold { get; }
        private TimeSpan FeeRateMedianTimeFrame { get; }

@lontivero lontivero merged commit a98b087 into WalletWasabi:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants