Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setting properties's names after the fallback mechanism removal #9650

Merged

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Nov 28, 2022

Follow-up to #9528 (comment)

I like the new names better as it's certainly more correct.

WDYT?

@kiminuo kiminuo force-pushed the feature/2022-11-28-follow-up-to-9528 branch from e0ad1a4 to ae29ea0 Compare November 28, 2022 10:29
@kiminuo kiminuo force-pushed the feature/2022-11-28-follow-up-to-9528 branch from ae29ea0 to a0cae0c Compare November 28, 2022 10:29
Copy link
Collaborator

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@kiminuo kiminuo marked this pull request as ready for review November 28, 2022 10:34
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@molnard molnard merged commit d312997 into WalletWasabi:master Nov 29, 2022
@kiminuo kiminuo deleted the feature/2022-11-28-follow-up-to-9528 branch November 29, 2022 11:56
kiminuo pushed a commit to kiminuo/WalletWasabi that referenced this pull request Nov 30, 2022
…follow-up-to-9528

Change setting properties's names after the fallback mechanism removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants