-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow to select coins if they are registered to a CJ round #9657
Don't allow to select coins if they are registered to a CJ round #9657
Conversation
WalletWasabi.Fluent/ViewModels/Wallets/Advanced/WalletCoins/WalletCoinViewModel.cs
Outdated
Show resolved
Hide resolved
WalletWasabi.Fluent/Views/Wallets/Advanced/WalletCoins/Columns/SelectionColumnView.axaml
Outdated
Show resolved
Hide resolved
WalletWasabi.Fluent/Views/Wallets/Advanced/WalletCoins/WalletCoinsView.axaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If an already selected coin gets registered into a conjoin meanwhile, the selection should be removed. ping @SuperJMN Can it be automatized in the current reactive logic with a simple code?
WalletWasabi.Fluent/Views/Wallets/Advanced/WalletCoins/Columns/SelectionColumnView.axaml
Outdated
Show resolved
Hide resolved
I think adding this to the // Remove selection when coin participated in a coinjoin.
this.WhenAnyValue(x => x.CoinJoinInProgress).Where(x => x).Subscribe(_ => IsSelected = false); |
This works. Thanks! Done in 831b5b0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
First part of #9541
This PR only works on the
CTRL+C+D
dialog.Next PR will tinker on the default send workflow.