Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow to select coins if they are registered to a CJ round #9657

Merged

Conversation

adamPetho
Copy link
Collaborator

@adamPetho adamPetho commented Nov 28, 2022

First part of #9541

This PR only works on the CTRL+C+D dialog.

Next PR will tinker on the default send workflow.

Szpoti
Szpoti previously approved these changes Nov 29, 2022
Copy link
Collaborator

@Szpoti Szpoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an already selected coin gets registered into a conjoin meanwhile, the selection should be removed. ping @SuperJMN Can it be automatized in the current reactive logic with a simple code?

@soosr
Copy link
Collaborator

soosr commented Nov 29, 2022

If an already selected coin gets registered into a conjoin meanwhile, the selection should be removed.

I think adding this to the WalletCoinViewModel should work.

// Remove selection when coin participated in a coinjoin.
this.WhenAnyValue(x => x.CoinJoinInProgress).Where(x => x).Subscribe(_ => IsSelected = false);

@adamPetho
Copy link
Collaborator Author

I think adding this to the WalletCoinViewModel should work.

// Remove selection when coin participated in a coinjoin.
this.WhenAnyValue(x => x.CoinJoinInProgress).Where(x => x).Subscribe(_ => IsSelected = false);

This works. Thanks!

Done in 831b5b0

Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants