Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logs part of Issue creation #9671

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

Szpoti
Copy link
Collaborator

@Szpoti Szpoti commented Nov 30, 2022

For more readable logs reported from the users, as some don't know you can use triple '`'s to format logs.

@Szpoti Szpoti requested review from MarnixCroes and yahiheb and removed request for MarnixCroes November 30, 2022 13:13
yahiheb
yahiheb previously approved these changes Nov 30, 2022
MarnixCroes
MarnixCroes previously approved these changes Nov 30, 2022
@@ -26,6 +26,10 @@ Example: Ubuntu 16.04

### Logs

```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad that log highlight is not supported as it is in Visual Studio code.

@kiminuo
Copy link
Collaborator

kiminuo commented Dec 1, 2022

A slight modification: https://pastebin.com/Ac7tUf8n

@Szpoti Szpoti dismissed stale reviews from MarnixCroes and yahiheb via 6e0a045 December 5, 2022 11:46
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Dec 5, 2022
Copy link
Collaborator Author

@Szpoti Szpoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added @kiminuo 's suggestion.

Comment on lines +24 to +25
*Please consider your privacy, before completing this section.*

Copy link
Collaborator Author

@Szpoti Szpoti Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed tho' under the Operating System title? Is revealing your OS here can be so harmful?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Better safe than sorry." is a good guiding principle. I don't know. It depends on one's level of privacy strictness.

But then it reminds me what is happening in browsers' world, people keep fingerprinting users by combining all known information about users (resolution, OS, etc.). So then you can narrow down that this was done by somebody, or you can find out that this person likely did not write something because he's a mac user and not a linux user. Life's complex.

```


You can find the `Logs.txt` file in the dropdown menu of the search bar or inside your Wasabi data folder or find `%PROFILE_PATH%/WalletWasabi/Client/Logs.txt` file.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I would extend the path with:
%PROFILE_PATH%/AppData/Roaming/WalletWasabi/Client/Logs.txt.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's Windows path, mine is more linuxy. I don't have any strict preference here. One can use your path, my path or specify all three for all operating systems. All are fine with me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, true, mine is windows specific, not everyone uses that. Leave it as it is.

kiminuo
kiminuo previously approved these changes Dec 5, 2022
Copy link
Collaborator

@kiminuo kiminuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahiheb yahiheb merged commit 4f6e8fd into WalletWasabi:master Dec 5, 2022
@Szpoti Szpoti deleted the issueTemplateUpdate branch December 6, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants